fix(address): support clustered usage #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 80.90% 81.08% +0.17%
==========================================
Files 2 2
Lines 110 111 +1
==========================================
+ Hits 89 90 +1
Misses 14 14
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Add `github.com/nats-io/nats.go` as an import - Change the `WithAddr` function signature to accept multiple addresses - Modify the `WithAddr` function to join multiple addresses with commas - Change the default address value to `nats.DefaultURL` Signed-off-by: Bo-Yi Wu <[email protected]>
- Modify the `go.yml` file in the `.github/workflows` directory - Add a new job called `nats01` in the `go.yml` file - Add a new job called `nats02` in the `go.yml` file - Modify the `.golangci.yml` file - Modify the `nats_test.go` file - Modify the `TestDefaultFlow` function in the `nats_test.go` file - Add a new function called `TestClusteredHost` in the `nats_test.go` file - Modify the `TestShutdown` function in the `nats_test.go` file - Modify the `TestCustomFuncAndWait` function in the `nats_test.go` file - Modify the `TestEnqueueJobAfterShutdown` function in the `nats_test.go` file - Modify the `TestJobReachTimeout` function in the `nats_test.go` file - Modify the `TestCancelJobAfterShutdown` function in the `nats_test.go` file - Modify the `TestGoroutineLeak` function in the `nats_test.go` file - Modify the `TestGoroutinePanic` function in the `nats_test.go` file - Modify the `TestReQueueTaskInWorkerBeforeShutdown` function in the `nats_test.go` file Signed-off-by: Bo-Yi Wu <[email protected]>
appleboy
added a commit
that referenced
this pull request
Dec 5, 2023
* feat: refactor `WithAddr` function to accept multiple addresses - Add `github.com/nats-io/nats.go` as an import - Change the `WithAddr` function signature to accept multiple addresses - Modify the `WithAddr` function to join multiple addresses with commas - Change the default address value to `nats.DefaultURL` Signed-off-by: Bo-Yi Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/nats-io/nats.goas an importWithAddrfunction signature to accept multiple addressesWithAddrfunction to join multiple addresses with commasnats.DefaultURLfix #35