Add support for js.Build/esbuild "loader" option #12879
Open
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianLeishman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #9978
related: #7697
related pr: stackkrocket@bc95ebc
I actually don't think the related PR is the correct way to go about this, since it only adds support for SVGs and adds it in an opinionated way. esbuild doesn't have a default loader for SVGs, and some libraries might choose to import the SVGs as something other than text, like a File object, base64, etc.
This PR adds support to specify the loader types for multiple extensions, using the same words as the official esbuild cli
https://esbuild.github.io/api/#loader
https://github.com/evanw/esbuild/blob/d34e79e2a998c21bb71d57b92b0017ca11756912/internal/config/config.go#L208
So here, more than just SVG support can be added, such as .ttf files (required by ckeditor, for example).
Usage example:
{{ $js := resources.Get `ts/index.ts` }} {{ $loaders := dict `.svg` `text` `.ttf` `text` }} {{ $opts := dict `target` `es2016` `minify` true `sourcemap` `external` `targetPath` `js/app.min.js` `loaders` $loaders }} {{ $js = $js | js.Build $opts | fingerprint }} <script src="{{ $js.RelPermalink }}"></script>I would be happy to add any needed tests or documentation for this, if it were to be accepted to move forward with.