-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : Server shouldn't start if HTTP_PORT is blocked #1319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add some test covering the new statements of code?
eeb76b0
I agree. I raised the point, I was not asking for one solution or another. With your feedbacks, I think you could simply consider the following:
It could help for tests. But you could also use a TestMain and set to freeport, and then no need to provide some in each tests Of course, it's out of the current PR I can help on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use free port
Description:
Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!