-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease log level for 4xx HTTP errors #1298
Conversation
@ccoVeille, a better name for the PR would be appreciated. |
@ccoVeille I tested your solution and it is working perfectly fine. And also it would be nice if you can add test for the newly added code. |
This PR target branch was your PR one @Umang01-hash It explains why the PR description was so basic. The tests were the ones you added. I should have mentioned and use draft. I was planning you to merge them in your branch, then keep the discussion running in your PR. I'll sort that, no worries. |
efb491e
to
f58450e
Compare
f58450e
to
fbd3401
Compare
I implemented here what I initially planned. But I felt like it was not a good way to do. Something that couldn't scale easily, So I provided an alternative implementation that would allow more than the current one. See For me, it supersedes the current PR, that now becomes pointless. |
Pull Request Template
Description:
Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!