Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server shouldn't start if HTTP_PORT is blocked #1243

Closed
surajit-zs opened this issue Nov 27, 2024 · 2 comments · Fixed by #1319
Closed

Server shouldn't start if HTTP_PORT is blocked #1243

surajit-zs opened this issue Nov 27, 2024 · 2 comments · Fixed by #1319
Assignees
@coolwednesday
Labels
enhancement New feature or request

Comments

@surajit-zs
Copy link
Contributor

If the HTTP_PORT is blocked the server should not start. Currently, it appears the server attempts to start even if the port is in use which can lead to issues.
This issue proposes that the server should perform a check before starting to ensure the HTTP_PORT is available. If the port is blocked, the server should fail to start and log an error message.
This enhancement will improve the reliability of the application and prevent unexpected behavior.

Screenshot 2024-11-27 at 11 40 53 AM
@coolwednesday
Copy link
Contributor

@Umang01-hash , please assign this issue to me.

@coolwednesday
Copy link
Contributor

coolwednesday commented Dec 9, 2024 •
edited
Loading

To address this issue, I will refactor the code to ensure that all required servers (gRPC, Pub/Sub, HTTP) are able to start successfully. If any of these servers fail to start, for example, due to a blocked port, we should shut down the entire application to maintain consistency and avoid partial availability.

@coolwednesday coolwednesday mentioned this issue Dec 19, 2024
Merged
4 tasks
@Umang01-hash Umang01-hash added the enhancement New feature or request label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coolwednesday coolwednesday

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix : Server shouldn't start if HTTP_PORT is blocked coolwednesday/gofr
3 participants
@Umang01-hash @surajit-zs @coolwednesday