metamask rejection fix #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisfenos
commented
Feb 14, 2019
chrisfenos
commented
- submitDeposit action delayed until after the error is thrown such that the metamask rejection error will not progress the components further.
…mponents do not advance
ansermino
requested changes
Mar 6, 2019
| this.props.updateDepositHash(txHash) | ||
| try { | ||
| const txHash = await executeDeposit(this.props.address, this.state.amount, this.props.networkID) | ||
| this.props.submitDeposit() |
There was a problem hiding this comment.
submitDeposit needs to happen before executeDeposit because it causes the UI to enter the loading state, otherwise it will only change once the deposit is submitted
There was a problem hiding this comment.
@ansermino the way it was set up after the refactor froze the application on errors with respect to the executeDeposit call. If you call the submitDeposit action first it will trigger the loading screen. If you know of a better way to handle this issue, otherwise we'd have to rewrite the logic throughout the app.
mrheyday
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.