responsive screen warning for mobile devices #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisfenos
commented
Feb 14, 2019
chrisfenos
commented
- disables any application interaction from mobile devices in the on-boarding section.
ansermino
requested changes
Mar 6, 2019
| @@ -36,6 +41,18 @@ class App extends Component { | |||
| }) | |||
| } | |||
|
|
|||
| componentDidMount = () => { | |||
| window.addEventListener('resize', this.updateDimensions); | |||
There was a problem hiding this comment.
Shouldn't update on resize, our concern is metamask not the actual size of the screen
There was a problem hiding this comment.
The initial issue was mobile devices & if a mobile screen is detected then do not display the bridge form. Because of the refactor in App.js its not easy to use any of the libraries for responsive screen sizes. @ansermino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.