Skip to content

default_key_mapping: Fix "Soft Reload Script" shortcut #11035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvuets
Copy link

@mvuets mvuets commented Jun 18, 2025

In Text Editor/Script Editor "Ctrl + Shift + R" is "Replace in files". The correct shortcut for "Soft Reload Script" is "Ctrl + Alt + R".

Reference: https://github.com/godotengine/godot/blob/4.4.1-stable/editor/plugins/script_editor_plugin.cpp#L4303:

file_menu->get_popup()->add_shortcut(ED_SHORTCUT("script_editor/reload_script_soft", TTRC("Soft Reload Tool Script"), KeyModifierMask::CMD_OR_CTRL | KeyModifierMask::ALT | Key::R), FILE_TOOL_RELOAD_SOFT);

In Text Editor/Script Editor "Ctrl + Shift + R" is "Replace in files".
The correct shortcut for "Soft Reload Script" is "Ctrl + Alt + R".

Reference: <https://github.com/godotengine/godot/blob/4.4.1-stable/editor/plugins/script_editor_plugin.cpp#L4303>:
    file_menu->get_popup()->add_shortcut(ED_SHORTCUT("script_editor/reload_script_soft", TTRC("Soft Reload Tool Script"), KeyModifierMask::CMD_OR_CTRL | KeyModifierMask::ALT | Key::R), FILE_TOOL_RELOAD_SOFT);
@@ -359,7 +359,7 @@ Script editor
+----------------------+---------------------------------+---------------------------------+----------------------------------------+
| Save All | :kbd:`Ctrl + Shift + Alt + S` | :kbd:`Cmd + Shift + Opt + S` | ``script_editor/save_all`` |
+----------------------+---------------------------------+---------------------------------+----------------------------------------+
| Soft Reload Script | :kbd:`Ctrl + Shift + R` | :kbd:`Cmd + Shift + R` | ``script_editor/reload_script_soft`` |
| Soft Reload Script | :kbd:`Ctrl + Alt + R` | :kbd:`Opt + Cmd + R` | ``script_editor/reload_script_soft`` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Soft Reload Script | :kbd:`Ctrl + Alt + R` | :kbd:`Opt + Cmd + R` | ``script_editor/reload_script_soft`` |
| Soft Reload Tool Script | :kbd:`Ctrl + Alt + R` | :kbd:`Opt + Cmd + R` | ``script_editor/reload_script_soft`` |

So unfortunately, the name of the shortcut has changed and would need to be updated. That also means every other box on this section would need to be updated as well. I don't want to merge this without the rename, but this might be better left for a PR that goes through everything to clean it up. I'm sure more of these are out of date, and also not in the same order in the editor anymore.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Shall I file a regular issue instead then?

@skyace65 skyace65 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.4 labels Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants