Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XR Deploying to android page for 4.4 #10594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skyace65
Copy link
Contributor

@skyace65 skyace65 commented Feb 1, 2025

Updates the page to Godot 4.4. That said there's almost no 4.4 specific changes in this, that's really just the screenshots. Though the page hasn't been updated in a while and a lot has changed over the last two Godot releases, hence a bunch of changes and re-organizing.

I've done the following:

  • Remove references to creating a debug.keystore file for android, that's done automatically in Godot 4.3 (Engine PR: Automatically generate the Android debug keystore godot#90611). Closes confusing/obsolete instruction in xr android deployment tutorial #10592
  • Moved the warning about which render to use to the setup section. I don't think that it makes sense to have it later in the page.
  • Removed the warning about the loaders plugin being renamed. If Bastiaan wants this back I'll re-add it, but I'm not sure how much value it provides right now
  • Updated the text to say look for the 4.3 version of the plugin, last time I checked with Bastiaan he wasn't sure how they were going to handle renaming it for 4.4 hence leaving it like that
  • Reword a section to avoid mentioning the specific plugin version, it's also now on 3.x instead of 2.x in terms of release number
  • Remove the section on enabling the vendors plugin entirely, you don't need to do that anymore since it uses GDExtension
  • rework the section on enabling a loader for better flow
  • Remove the image showing Meta XR features you can enable. It's out of date and the plugin has so many features now you can't fit them all in a single screenshot
  • Update text to reflect that there are Pico specific features now

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 1, 2025
@skyace65 skyace65 added this to the 4.4 milestone Feb 1, 2025
@skyace65 skyace65 requested a review from BastiaanOlij February 1, 2025 03:03
@skyace65 skyace65 added the topic:xr Related to XR documentation label Feb 1, 2025
The vendors plugin can be downloaded from the asset library, search for "OpenXR
vendors" and install the one named "Godot OpenXR Vendors plugin for Godot 4.3".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The vendors plugin can be downloaded from the asset library, search for "OpenXR
vendors" and install the one named "Godot OpenXR Vendors plugin for Godot 4.3".
The vendors plugin can be downloaded from the asset library, search for "OpenXR vendors"
and install the one named "Godot OpenXR Vendors plugin for Godot 4.3".

Better readability for the raw text

@skyace65
Copy link
Contributor Author

skyace65 commented Feb 1, 2025

Applied AThousandShips suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:xr Related to XR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing/obsolete instruction in xr android deployment tutorial
3 participants