Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Python-related files to gitignore #10572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maarrk
Copy link
Contributor

@Maarrk Maarrk commented Jan 29, 2025

I tend to name all my environments venv, but there's also a bunch of tooling assuming that. Makes the workflow more friendly because you don't see an explosion of files in git.

Based on https://www.toptal.com/developers/gitignore/api/python which is under CC0 license, took a moment to organize the file similarly

Yo dawg, I heard you like venv, so we put more venv in your .gitignore so you can ignore venv while you git

@AThousandShips AThousandShips added enhancement python Pull requests that update Python code labels Jan 29, 2025
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning makes sense, and it makes sense to cover a wide range of common environment names since the docs are edited by a lot of contributors that we can't enforce a common workflow on.

I don't know enough python to review the details, though. Would appreciate other reviews.

For future reference the CC0 license is specified here (permalink); it's not specified in the linked file in the PR itself. But a gitignore likely falls under fair use anyway?

@Maarrk
Copy link
Contributor Author

Maarrk commented Feb 1, 2025

But a gitignore likely falls under fair use anyway?

I am not a lawyer, but these few lines are too trivial to have any discussion of copyright over them.

I only added that remark to show that they aren't my idea but come from a widely used source, to make it easier to trust for maintainers. Here is the same content under the same license from GitHub itself:

https://github.com/github/gitignore/blob/297239c101dcfdfae7e75757ed17ed993df0b4eb/Python.gitignore#L130-L137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants