Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document adding scene-unique nodes by prefixing with '%' #10514

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Synzorasize
Copy link
Contributor

This feature was added in godotengine/godot#101163. Therefore it should probably be documented here so that users don't miss it. Feel free to request changes.

@AThousandShips AThousandShips added this to the 4.4 milestone Jan 17, 2025
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 17, 2025
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to merge as-is, but better with the changes suggested here.

As a side note, in a later PR we might want to double check all the places we refer to "scene unique nodes" and make sure they are aligned in terminology. As best I can tell, in the Godot editor UI itself, the phrase "scene unique node" is not used, but "Access as Unique Name" is. The tooltip also doesn't mention "scene unique node" anywhere:
Godot_v4 4-beta1_win64_zynAMYiYEW

So it's an interesting situation where the docs call it one thing but the editor doesn't seem to have a name for it.

tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
@mhilbrunner mhilbrunner merged commit fb685d9 into godotengine:master Jan 22, 2025
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants