Disable double precisions builds in CI for now #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
dsnopek
changed the title
Ivorforce
approved these changes
Jun 20, 2025
|
No one has objected, so I'm going to merged this and unbreak the build. We can continue discussing how to support double precision builds in CI elsewhere |
|
Cherry-picked for 4.4 in PR #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godot-cpp's CI does some double precision builds, however, it's using the
extension_api.jsonin the repo which is from a single precision build, and hence shouldn't be used for this purpose.In #1714, we added some protections to stop users from doing this, but they hadn't kicked in yet because we needed an updated
extension_api.jsonthat included precision informationCommit 61f52cb synchronized the
extension_api.jsonwith 4.5-beta1 which includes this information, and now CI is failing... And it should fail because this not a valid build!This PR just removes the double precision builds for now.
I also can't ever recall these tests ever failing before, so it's not like they've been helping us catch bugs or anything. (These builds would never have actually worked, given that we were using the wrong
extension_api.jsonanyway)If we want to add double precision builds back, that's fine, but we'll need to figure out how to do them. I don't really want to add a double precision
extension_api.jsonto the repo, because I want the JSON we release with to be from official builds, and there are no official builds with double precision. So, we'll need some solution to that.