Skip to content

Fix binding generation for TypedArray/TypedDictionary with refcounted elements. #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 18, 2025

See godotengine/godot#107660

It was generating invalid TypedDictionary<String, Font> type, now it's TypedDictionary<String, Ref<Font>>. Existing bindings should not change.

@bruvzg bruvzg requested a review from a team as a code owner June 18, 2025 10:21
@bruvzg bruvzg added bug This has been identified as a bug enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jun 18, 2025
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I haven't tested, but the code looks good to me

@dsnopek dsnopek merged commit e17a5a7 into godotengine:master Jun 20, 2025
18 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 24, 2025

Cherry-picked for 4.4 in PR #1805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants