Skip to content

Clean up the MethodBind class #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

tomfull123
Copy link
Contributor

Renamed and reordered variables and methods to be more consistent with godot, it's not 100% since there are some additional methods and some methods missing.

This PR shouldn't change any functionality, its purely refactoring.

@tomfull123 tomfull123 requested a review from a team as a code owner April 20, 2025 19:36
@tomfull123 tomfull123 force-pushed the method-bind-clean-up branch from c9e5bdd to 8f57a47 Compare April 20, 2025 19:37
@tomfull123 tomfull123 force-pushed the method-bind-clean-up branch from 8f57a47 to ca5af3c Compare April 20, 2025 19:47
@dsnopek dsnopek added enhancement This is an enhancement on the current functionality cherrypick:4.3 cherrypick:4.4 labels Jun 18, 2025
@dsnopek dsnopek added this to the 4.x milestone Jun 18, 2025
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I compared these changes with what we have in Godot, and this looks good to me :-)

@AThousandShips AThousandShips changed the title Cleaned up the MethodBind class Clean up the MethodBind class Jun 18, 2025
@dsnopek dsnopek merged commit 5a0d656 into godotengine:master Jun 20, 2025
18 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 24, 2025

Cherry-picked for 4.3 in PR #1803

@dsnopek
Copy link
Collaborator

dsnopek commented Jun 24, 2025

Cherry-picked for 4.4 in PR #1805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants