Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the hide and restore functionality #289

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Piralein
Copy link
Member

@Piralein Piralein commented Jun 20, 2023

Exposes the hide/restore functionality to the author of the asset.

Problems:

  • Hidden assets are currently not linked anywhere for the owner or moderator. (unless I missed it)
  • Hidden assets are still viewable with a direct link

Solution/Changes:

  • Expose the asset to authors and moderators if the user filter is used. (default My Assets link functionality)
  • Hidden assets can only be viewed by the author or a moderator, otherwise it will throw a not found error.
  • Restructured the asset view to be more clear
  • Add a author tools container in the same way as the admin tools container.

Hidden asset in my assets:
my_assets

Asset view:
asset

@Piralein Piralein force-pushed the deleteornotdeletequestionmarkhintdoubledotitsnot branch from 0cacdb8 to 6e092bb Compare June 21, 2023 16:20
@coppolaemilio
Copy link
Member

@Piralein is this PR still a draft? what are the steps needed to finish it up? Thanks :)

@Piralein
Copy link
Member Author

I haven't tested the API side. It could have unexpected problems, because of the change to the query and login token validation.
I can't remember what I considered as a problem specifically.
The website part should be ready, but I need to re-test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants