Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syn requirement from 1 to 2 #1042

Closed
wants to merge 1 commit into from
Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 20, 2023

Updates the requirements on syn to permit the latest version.

Release notes

Sourced from syn's releases.

2.0.2

  • Documentation improvements
Commits
  • cac5cc6 Release 2.0.2
  • 8f826ef Touch up spacing in example for parse_multi_with_leading_vert
  • fc58fcf Fix typo in Stmt::Macro documentation
  • e298152 Release 2.0.1
  • b87a0a1 Merge pull request #1409 from dtolnay/requiremeta
  • 59dd7cc Add methods on Meta for error reporting an incorrect kind of attribute
  • 11c0b6c Build attribute parse errors using std::fmt system
  • e6cf741 Move parse_args_with error handler into parsing module
  • 906fa56 Release 2.0.0
  • 29bd855 Fix warning about Cargo.toml exclude/include
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [syn](https://github.com/dtolnay/syn) to permit the latest version.
- [Release notes](https://github.com/dtolnay/syn/releases)
- [Commits](dtolnay/syn@1.0.0...2.0.2)

---
updated-dependencies:
- dependency-name: syn
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies PRs updating dependencies (dependabot automation) label Mar 20, 2023
@chitoyuu
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Mar 20, 2023
@bors
Copy link
Contributor

bors bot commented Mar 20, 2023

try

Build failed:

@chitoyuu
Copy link
Contributor

Appears that manual intervention would be required for the update.

@Bromeon
Copy link
Member

Bromeon commented Mar 21, 2023

Here is the author's page talking about the release and the breaking changes involved.

Over time, it's probably in our interest to update, as users otherwise have both syn 1 and 2 in their paths (through transitive dependencies like serde, inventory etc), increasing compile times.

@chitoyuu
Copy link
Contributor

Indeed. There might also eventually come a point where this becomes blocking for users, when Rust introduces new syntax that can no longer be parsed by syn 1.x. I agree that it's best to update at some point, possibly sooner than later to avoid blocking any work on the macros.

@Bromeon
Copy link
Member

Bromeon commented Apr 6, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 6, 2024

Superseded by #1075.

@dependabot dependabot bot closed this Apr 6, 2024
@dependabot dependabot bot deleted the dependabot/cargo/syn-2 branch April 6, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs updating dependencies (dependabot automation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants