[WIP] Godot 4 #13
[WIP] Godot 4 #13
Conversation
| @@ -1,14 +1,14 @@ | |||
| # Godot Package Manager plugin for godot | |||
| # Godot Package Manager plugin for Godot 4 | |||
There was a problem hiding this comment.
when do we want to merge this, and how do we make the 3.x version usable?
There was a problem hiding this comment.
Godot 4.0 is releasing soon, so we would want to release GPM as soon as possible. The 3.x version can stay as is as long as it's still usable.
There was a problem hiding this comment.
But, like, do we make a 3.x branch or just make a release?
There was a problem hiding this comment.
Spliting into a 3.x branch and master + a release makes sense
|
|
||
| ## Get the name without the scope. Necessary for creating directories since the scope | ||
| ## can contain an "@" character. | ||
| func unscoped_name() -> String: |
There was a problem hiding this comment.
i think we should remove this, i removed this for the cli, and npm doesnt do this.
having scope be a directory is totally fine.
| ## | ||
| ## Returns: [br] | ||
| ## [param Dictionary] - The response parsed into a [Dictionary]. | ||
| static func post_request( |
There was a problem hiding this comment.
eventually for npm search (I think)
There was a problem hiding this comment.
Then I'll remove it if it's not being used before the stable release. I'm sure I can find a use for it though
| static func get_tarball_url(package_name: String, version: String) -> String: | ||
| var response := await get_manifest(package_name, version) | ||
| if response.is_empty(): | ||
| printerr("get_tarball_url response was empty") | ||
| return "" | ||
|
|
||
| return response.get("dist", {}).get("tarball", "") |
There was a problem hiding this comment.
| static func get_tarball_url(package_name: String, version: String) -> String: | |
| var response := await get_manifest(package_name, version) | |
| if response.is_empty(): | |
| printerr("get_tarball_url response was empty") | |
| return "" | |
| return response.get("dist", {}).get("tarball", "") | |
| static func get_tarball_url(package_name: String, unscoped_package_name, package_version: String) -> String: | |
| return "%s/%s/-/%s-%s.tgz" % [REGISTRY, package_name, unscoped_package_name, package_version] | |
| # https://registry.npmjs.org/@bendn/splitter/-/splitter-1.0.6.tgz |
I wonder if this would work
There was a problem hiding this comment.
Maybe as an optimization to remove 1 GET request.
Could split it into:
get_tarball_url_blind and get_tarball_url
There was a problem hiding this comment.
the docs say usually in the form of https://registry.npmjs.org/<name>/-/<name>-<version>.tgz... so i guess its not reliable? hmm.
|
|
||
| ## Default headers to use when sending requests. | ||
| const HEADERS := [ | ||
| "User-Agent: GodotPackageManager/1.0 (godot-package-manager on GitHub)", |
There was a problem hiding this comment.
| "User-Agent: GodotPackageManager/1.0 (godot-package-manager on GitHub)", | |
| "User-Agent: GodotPackageManager/0.1.0 (godot-package-manager on GitHub)", |
plugin.cfg says its 0.1.0
There was a problem hiding this comment.
User agents don't usually use 3 numbers for the first identifier. example
There was a problem hiding this comment.
I wasnt aware there was a standard. Whats wrong with ditching the standard though?
There was a problem hiding this comment.
I guess we can since everyone else just uses the same mozilla user agent anyways
Core
GUI is still extremely unfinished.