responderListFilePath as an object#40
Open
stephane-tessier wants to merge 19 commits intogoddyZhao:masterfrom
Open
responderListFilePath as an object#40stephane-tessier wants to merge 19 commits intogoddyZhao:masterfrom
stephane-tessier wants to merge 19 commits intogoddyZhao:masterfrom
Conversation
0194cdc to
941bb79
Compare
I wanna be able to give an options object via nodejs (`nproxy(port, options)`), and pass the `responderListFilePath` directly as an object. Maybe this is not the cleanest way to do this, but I didn't want to refactorize too much code.
updating url repo in package.json
Fix: no file watcher if direct configuration
2480a6d to
2ede365
Compare
2ede365 to
0a357c4
Compare
deprecated fix + updates deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanna be able to give an options object via nodejs (
nproxy(port, options)), and pass theresponderListFilePathoption directly as an object.Maybe this is not the cleanest way to do this, but I didn't want to refactorize too much code.