Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Enhanced navigation feature integration #718

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

nmolham-godaddy
Copy link
Contributor

Summary

Removes support for the deprecated Enhanced navigation feature.

Story: MWC-17476

QA

  • Code review

Before merge

  • I have confirmed these changes in each supported minor WooCommerce version

Copy link
Contributor

@ajaynes-godaddy ajaynes-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of missing docblocks on new methods here. I couldn't remember if we can use a version placeholder that the build script replaces or not so I just went with the next patch release version for the @since annotations.

woocommerce/class-sv-wc-helper.php Show resolved Hide resolved
woocommerce/class-sv-wc-helper.php Show resolved Hide resolved
@ajaynes-godaddy ajaynes-godaddy merged commit 97a4dee into master Oct 1, 2024
5 checks passed
@ajaynes-godaddy ajaynes-godaddy deleted the chore/deprecate-navigation-feature-support branch October 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants