Account for Subscriptions Core library when checking for Subscriptions #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfulvio
requested review from
nikolas4175-godaddy,
nmolham-godaddy and
itambek-godaddy
Co-authored-by: Nabeel Molham <[email protected]>
nmolham-godaddy
deleted the
fix/is-subscriptions-active-should-also-check-for-standalone-lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WooCommerce Subscriptions might exist as a split library from https://github.com/Automattic/woocommerce-subscriptions-core -- this library includes nearly all the functionalities from WooCommerce Subscriptions.
If a plugin or third party code uses this library, gateways or plugins that use this framework and integrate with Subscriptions won't work because this framework only checks if the Subscriptions plugin is active, not the standalone lib.
The checks in this PR have been updated to account for that possibility.