Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build process #714

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Fix build process #714

merged 6 commits into from
Sep 5, 2024

Conversation

nmolham-godaddy
Copy link
Contributor

@nmolham-godaddy nmolham-godaddy commented Sep 4, 2024 •
edited by agibson-godaddy
Loading

Summary

Fixing the SASS and POT file building processes.

Details

  • Using the correct source-map option for sass
  • Adding the correct options for WP CLI for making the POT file

QA

  • Code review
  • SASS and POT files are compile correctly running npm run build

Before merge

  • I have confirmed these changes in each supported minor WooCommerce version

@nmolham-godaddy nmolham-godaddy self-assigned this Sep 4, 2024
agibson-godaddy
agibson-godaddy reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@agibson-godaddy agibson-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!! Just one suggestion.

grunt/configs/shell.js Outdated Show resolved Hide resolved
@ajaynes-godaddy
Copy link
Contributor

QA seems to check out.

agibson-godaddy
agibson-godaddy approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@agibson-godaddy agibson-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!

@agibson-godaddy agibson-godaddy merged commit 3ea6571 into master Sep 5, 2024
5 checks passed
@agibson-godaddy agibson-godaddy deleted the chore/fix-build-process branch September 5, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibson-godaddy agibson-godaddy agibson-godaddy approved these changes

@nikolas4175-godaddy nikolas4175-godaddy Awaiting requested review from nikolas4175-godaddy

@itambek-godaddy itambek-godaddy Awaiting requested review from itambek-godaddy

@ajaynes-godaddy ajaynes-godaddy Awaiting requested review from ajaynes-godaddy

Assignees

@nmolham-godaddy nmolham-godaddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmolham-godaddy @ajaynes-godaddy @agibson-godaddy