Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crane agent panic when handling ext memory pods. #891

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

payall4u
Copy link
Collaborator

What type of PR is this?

bugfix

What this PR does / why we need it:

Crane agent will panic if we use ext memory. Fix it.

Which issue(s) this PR fixes:

Fixes #889

Special notes for your reviewer:

@payall4u payall4u requested a review from mfanjie January 21, 2024 02:12
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2024-01-21 10:32
Git Version: ea20086

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-891-ea20086 docker pull gocrane/crane-agent:pr-891-ea20086
dashboard:pr-891-ea20086 docker pull gocrane/dashboard:pr-891-ea20086
metric-adapter:pr-891-ea20086 docker pull gocrane/metric-adapter:pr-891-ea20086
craned:pr-891-ea20086 docker pull gocrane/craned:pr-891-ea20086

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-891-ea20086 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-891-ea20086 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-891-ea20086 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-891-ea20086 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-891-ea20086 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-891-ea20086
dashboard:pr-891-ea20086 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-891-ea20086
metric-adapter:pr-891-ea20086 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-891-ea20086
craned:pr-891-ea20086 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-891-ea20086

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-891-ea20086 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-891-ea20086 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-891-ea20086 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-891-ea20086 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-891-ea20086 docker pull ghcr.io/gocrane/crane/crane-agent:pr-891-ea20086
dashboard:pr-891-ea20086 docker pull ghcr.io/gocrane/crane/dashboard:pr-891-ea20086
metric-adapter:pr-891-ea20086 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-891-ea20086
craned:pr-891-ea20086 docker pull ghcr.io/gocrane/crane/craned:pr-891-ea20086

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-891-ea20086 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-891-ea20086 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-891-ea20086 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-891-ea20086 crane/crane

Copy link
Contributor

@mfanjie mfanjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfanjie mfanjie merged commit ed43bd2 into gocrane:main Jan 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crane-agent may panic when used ExtResource gocrane.io/memory
2 participants