Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oom record sort #883

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix oom record sort #883

merged 1 commit into from
Mar 15, 2024

Conversation

whitebear009
Copy link
Contributor

@whitebear009 whitebear009 commented Jan 1, 2024

What type of PR is this?

bug fix

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #844

Special notes for your reviewer:

Copy link
Contributor

github-actions bot commented Jan 1, 2024

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2024-01-01 23:55
Git Version: 832e1bc

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-883-832e1bc docker pull gocrane/crane-agent:pr-883-832e1bc
dashboard:pr-883-832e1bc docker pull gocrane/dashboard:pr-883-832e1bc
metric-adapter:pr-883-832e1bc docker pull gocrane/metric-adapter:pr-883-832e1bc
craned:pr-883-832e1bc docker pull gocrane/craned:pr-883-832e1bc

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-883-832e1bc \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-883-832e1bc \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-883-832e1bc \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-883-832e1bc crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-883-832e1bc docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-883-832e1bc
dashboard:pr-883-832e1bc docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-883-832e1bc
metric-adapter:pr-883-832e1bc docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-883-832e1bc
craned:pr-883-832e1bc docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-883-832e1bc

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-883-832e1bc \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-883-832e1bc \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-883-832e1bc \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-883-832e1bc crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-883-832e1bc docker pull ghcr.io/gocrane/crane/crane-agent:pr-883-832e1bc
dashboard:pr-883-832e1bc docker pull ghcr.io/gocrane/crane/dashboard:pr-883-832e1bc
metric-adapter:pr-883-832e1bc docker pull ghcr.io/gocrane/crane/metric-adapter:pr-883-832e1bc
craned:pr-883-832e1bc docker pull ghcr.io/gocrane/crane/craned:pr-883-832e1bc

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-883-832e1bc \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-883-832e1bc \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-883-832e1bc \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-883-832e1bc crane/crane

Copy link
Contributor

@mfanjie mfanjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfanjie mfanjie merged commit c73e558 into gocrane:main Mar 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/oom/recorder.go cleanOOMRecord函数保留的record问题
2 participants