Upgrade to hpa v2 and update to k8s 1.23 #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsnmwy
requested changes
Jul 19, 2023
.github/workflows/go.yml
Outdated
| @@ -16,7 +16,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.17 | |||
| go-version: 1.20 | |||
There was a problem hiding this comment.
Suggested change
| go-version: 1.20 | |
| go-version: '>=1.2.0' |
.github/workflows/go.yml
Outdated
| @@ -82,7 +82,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.17 | |||
| go-version: 1.20 | |||
There was a problem hiding this comment.
Suggested change
| go-version: 1.20 | |
| go-version: '>=1.2.0' |
.github/workflows/go.yml
Outdated
| @@ -115,7 +115,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.17 | |||
| go-version: 1.20 | |||
There was a problem hiding this comment.
Suggested change
| go-version: 1.20 | |
| go-version: '>=1.2.0' |
.github/workflows/go.yml
Outdated
| @@ -148,7 +148,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.17 | |||
| go-version: 1.20 | |||
There was a problem hiding this comment.
Suggested change
| go-version: 1.20 | |
| go-version: '>=1.2.0' |
.github/workflows/go.yml
Outdated
| @@ -182,7 +182,7 @@ jobs: | |||
| uses: actions/[email protected] | |||
| with: | |||
| # The Go version to download (if necessary) and use. Supports semver spec and ranges. | |||
| go-version: 1.17 # optional | |||
| go-version: 1.20 # optional | |||
There was a problem hiding this comment.
Suggested change
| go-version: 1.20 # optional | |
| go-version: '>=1.2.0' |
qmhu
force-pushed
the
support-v1.26+
branch
4 times, most recently
from
a9fd319
to
456f043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: