Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find the Orphan Volume in k8s cluster #784

Merged
merged 4 commits into from
May 24, 2023
Merged

Find the Orphan Volume in k8s cluster #784

merged 4 commits into from
May 24, 2023

Conversation

liu-song
Copy link
Contributor

What type of PR is this?

Find the Orphan Volume in k8s cluster

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #738

Special notes for your reviewer:

@liu-song liu-song changed the title Find the Orphan Volume in k8s cluster wip:Find the Orphan Volume in k8s cluster May 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-05-24 20:25
Git Version: 7c3e187

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-784-7c3e187 docker pull gocrane/crane-agent:pr-784-7c3e187
dashboard:pr-784-7c3e187 docker pull gocrane/dashboard:pr-784-7c3e187
metric-adapter:pr-784-7c3e187 docker pull gocrane/metric-adapter:pr-784-7c3e187
craned:pr-784-7c3e187 docker pull gocrane/craned:pr-784-7c3e187

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-784-7c3e187 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-784-7c3e187 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-784-7c3e187 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-784-7c3e187 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-784-7c3e187 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-784-7c3e187
dashboard:pr-784-7c3e187 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-784-7c3e187
metric-adapter:pr-784-7c3e187 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-784-7c3e187
craned:pr-784-7c3e187 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-784-7c3e187

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-784-7c3e187 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-784-7c3e187 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-784-7c3e187 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-784-7c3e187 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-784-7c3e187 docker pull ghcr.io/gocrane/crane/crane-agent:pr-784-7c3e187
dashboard:pr-784-7c3e187 docker pull ghcr.io/gocrane/crane/dashboard:pr-784-7c3e187
metric-adapter:pr-784-7c3e187 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-784-7c3e187
craned:pr-784-7c3e187 docker pull ghcr.io/gocrane/crane/craned:pr-784-7c3e187

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-784-7c3e187 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-784-7c3e187 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-784-7c3e187 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-784-7c3e187 crane/crane

pkg/recommendation/framework/context.go Outdated Show resolved Hide resolved
pkg/recommendation/framework/context.go Outdated Show resolved Hide resolved
pkg/recommendation/recommender/volumes/filter.go Outdated Show resolved Hide resolved
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以参考下service plugin的实现

pkg/recommendation/framework/context.go Outdated Show resolved Hide resolved
@qmhu qmhu added the bootcamp label May 11, 2023
# Conflicts:
#	pkg/recommendation/manager.go
@liu-song liu-song changed the title wip:Find the Orphan Volume in k8s cluster Find the Orphan Volume in k8s cluster May 23, 2023
@liu-song liu-song requested a review from qmhu May 23, 2023 07:05
@qmhu
Copy link
Member

qmhu commented May 24, 2023

@liu-song you can also submit a pr for docs with PV Recommender if you have free time.

@qmhu qmhu closed this May 24, 2023
@qmhu qmhu reopened this May 24, 2023
@qmhu qmhu merged commit 060314e into gocrane:main May 24, 2023
@liu-song liu-song deleted the volume branch May 25, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume Plugin
3 participants