Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复添加集群中的 CRANE URL 正常输入时 无法输入 反斜杠问题 #769

Closed
wants to merge 6 commits into from

Conversation

RuoChengF
Copy link

针对问题
#768 进行修复

去掉原有的只匹配 "/" 的校验 换成正则的域名校验

@qmhu qmhu requested a review from zsnmwy May 8, 2023 02:56
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-05-08 11:07
Git Version: 82d3228

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-769-82d3228 docker pull gocrane/crane-agent:pr-769-82d3228
dashboard:pr-769-82d3228 docker pull gocrane/dashboard:pr-769-82d3228
metric-adapter:pr-769-82d3228 docker pull gocrane/metric-adapter:pr-769-82d3228
craned:pr-769-82d3228 docker pull gocrane/craned:pr-769-82d3228

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-769-82d3228 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-769-82d3228 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-769-82d3228 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-769-82d3228 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-769-82d3228 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-769-82d3228
dashboard:pr-769-82d3228 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-769-82d3228
metric-adapter:pr-769-82d3228 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-769-82d3228
craned:pr-769-82d3228 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-769-82d3228

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-769-82d3228 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-769-82d3228 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-769-82d3228 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-769-82d3228 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-769-82d3228 docker pull ghcr.io/gocrane/crane/crane-agent:pr-769-82d3228
dashboard:pr-769-82d3228 docker pull ghcr.io/gocrane/crane/dashboard:pr-769-82d3228
metric-adapter:pr-769-82d3228 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-769-82d3228
craned:pr-769-82d3228 docker pull ghcr.io/gocrane/crane/craned:pr-769-82d3228

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-769-82d3228 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-769-82d3228 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-769-82d3228 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-769-82d3228 crane/crane

@qmhu
Copy link
Member

qmhu commented May 9, 2023

Please remove the Chinese commit history.

@RuoChengF
Copy link
Author

ok

@RuoChengF
Copy link
Author

Created a new branch to commit this branch can be deleted thanks

@RuoChengF RuoChengF closed this May 25, 2023
@RuoChengF RuoChengF deleted the regChange branch May 25, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants