Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-adapter expression]some change about metricRule prase #726

Merged
merged 6 commits into from
Jul 3, 2023

Conversation

saikey0379
Copy link
Contributor

1.avoid panic when adapter-configmap is nil
2.take a Real-time synchron if config was changed
3.skiped when metricRule prase err to keep other metric health
4.add monitor for metricRules prase

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-06-09 14:25
Git Version: 92873d8

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-726-92873d8 docker pull gocrane/crane-agent:pr-726-92873d8
dashboard:pr-726-92873d8 docker pull gocrane/dashboard:pr-726-92873d8
metric-adapter:pr-726-92873d8 docker pull gocrane/metric-adapter:pr-726-92873d8
craned:pr-726-92873d8 docker pull gocrane/craned:pr-726-92873d8

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-726-92873d8 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-726-92873d8 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-726-92873d8 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-726-92873d8 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-726-92873d8 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-726-92873d8
dashboard:pr-726-92873d8 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-726-92873d8
metric-adapter:pr-726-92873d8 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-726-92873d8
craned:pr-726-92873d8 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-726-92873d8

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-726-92873d8 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-726-92873d8 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-726-92873d8 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-726-92873d8 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-726-92873d8 docker pull ghcr.io/gocrane/crane/crane-agent:pr-726-92873d8
dashboard:pr-726-92873d8 docker pull ghcr.io/gocrane/crane/dashboard:pr-726-92873d8
metric-adapter:pr-726-92873d8 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-726-92873d8
craned:pr-726-92873d8 docker pull ghcr.io/gocrane/crane/craned:pr-726-92873d8

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-726-92873d8 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-726-92873d8 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-726-92873d8 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-726-92873d8 crane/crane

@qmhu qmhu merged commit 2466bae into gocrane:main Jul 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants