-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fields redux store #108
Fields redux store #108
Conversation
@eri-trabiccolo mostly requesting a review to help test and make sure nothings gone haywire here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Dependency Scan (nodejs) | 3 | 20 | 14 | 2 | ❌ |
Security Audit for Infrastructure | 0 | 0 | 0 | 0 | ✅ |
PHP Security Analysis | 0 | 0 | 0 | 0 | ✅ |
PHP Security Audit | 0 | 0 | 3 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh this is a quite big one.
Overall I like it, need to test it a little bit.
E.g. I've found that clearing a field's name because you want to replace the default name with another one is "impossible". The notice The name "" is not unique. Please choose a globally unique field name.
appears and
key
name
id
attributes get regenerated.
I see I can duplicate some llms core reusable blocks, e.g. the phone number. Is this expected? |
Also weird thing, looks like the confirmation fields do not display anymore in the editor? [regression] |
…ode and add a filter on the safelist
…cks denoted as llms field blocks
Co-authored-by: Rocco Aliberti <[email protected]>
How are you going about doing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset pretty good to me, I like the new warning system.
…plicate field identification
Description
Closes: #103
Closes: #104
Closes: https://github.com/orgs/gocodebox/projects/12#card-62005666
How has this been tested?
Manually, and it needs more manual testing
E2E tests to be written
Screenshots
Types of changes
Bug fixes & new features
Checklist: