Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique field names handling needs to be improved(?) #103

Closed
1 of 4 tasks
eri-trabiccolo opened this issue Jun 1, 2021 · 1 comment
Closed
1 of 4 tasks

Unique field names handling needs to be improved(?) #103

eri-trabiccolo opened this issue Jun 1, 2021 · 1 comment
Assignees
Labels

Comments

@eri-trabiccolo
Copy link
Contributor

Reproduction Steps

  • Edit a form and create a field, using the hame "whatever"
  • Turn it to a reusable block and save it
  • Create or edit another form and add the reusable block just created
  • turn the reusable block into a normal block
  • Alter the label, the description, whatever (but not the name)
  • save the form

Expected Behavior

  • I'd expect to not be able to save the field, which is not a reusable field anymore, because it has a non unique name

Actual Behavior

  • I can save the form with the field that has a non unique name

Error Messages / Logs

n/a

System and Environment Information

dafd798

###This issue has be recreated:

  • Locally
  • On a staging site
  • On a production website
  • With only LifterLMS and a default theme

Browser, Device, and Operating System Information

n/a

@eri-trabiccolo eri-trabiccolo added Severity: Normal Type: Enhancement Improvements existing features or code labels Jun 1, 2021
@thomasplevy
Copy link
Contributor

This is nearly identical to #104 but not exactly. It's all interrelated in that our automatically generated values / validation isn't working right in these scenarios.

@thomasplevy thomasplevy self-assigned this Jun 2, 2021
@thomasplevy thomasplevy added Type: Bug Bugs and errors and removed Type: Enhancement Improvements existing features or code labels Jun 2, 2021
@thomasplevy thomasplevy mentioned this issue Jun 9, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants