Code signing for binaries #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses gocd-contrib#26
ketan
reviewed
Mar 29, 2019
There was a problem hiding this comment.
With batch files and shell scripts, there is a high likelihood that the next person who edits it does not do error handling and leaving a bad build look green. This has actually happened with me, several times.
So is it possible we just use rake for this instead?
|
@ketan fair enough - I'll need to do the same with the installer trial launcher build as well; the existing rake task for macos wasn't workable for non- |
|
Merging this one for now and @ibnc will create a new PR to migrate to rake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #26
@marques-work mind taking a look? I'll leave the test pipeline until you've taken a look. It's named
gocd-cli-testing