-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control sources and pipewire compatible #4
base: master
Are you sure you want to change the base?
Conversation
@eylles thank you! the PR looks good, could you fix the conflicts to make this mergeable? Also, instead of |
after having dealt with a PR to a module that had a boolean in the input table i will have to say yes, i guess keeping the vars table as is should be okay. also i'm changing the |
renamed the module's vars and changed var type from boolean to string.
i couldn't figure out a way to make this fully async without a substantial rewrite, as such i've decided to take that route and write my own sound widget from scratch. please do not feel obligated to merge this PR, it has quite some substantial changes in the logic and working of the widget for making it work only with pactl for starters i replaced pacmd with the pactl commands |
should have opened this before your most recent commit, will have to resolve conflicts but for now i opened for visibility.
this PR not only adds the abilty to control pulse sources but also makes an important change, instead of parsing the output of pacmd now it parses the output of 2 paclt commands which get the mute or volume of the default sink (or source).
this should make the internal logic a bit simpler i guess on top of giving pipewire support, mind you i have not tested how this behaves with pipewire since my setup still uses pulse.
eventually i would like to migrate this module from using io.popen to use one of the async functions of awesomewm perhaps awful.spawn.with_line_callback but i'm leaving that for another PR