web: add additional context to event log messages#23670
Open
Benricheson101 wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23670 +/- ##
==========================================
+ Coverage 93.15% 93.19% +0.04%
==========================================
Files 1037 1039 +2
Lines 60658 60901 +243
Branches 400 424 +24
==========================================
+ Hits 56506 56757 +251
+ Misses 4152 4144 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Updates event log messages to be more descriptive
What does this PR change?
Adds context to event log messages
The Model messages just add the model type to the title. "Login failed" events add a new
context.reasonfield in their API response containing the reason the login failed.Why is this change needed?
It's hard to tell what's being modified or the reason for login failures from a glance. This adds it front and center so it's easier for admins to see what was changed or why a login failed without expanding each logged event.
How was this tested?
Updating existing tests to test new API fields.
Linked issues
closes #23193
Checklist
make all)make docs)