tasks: add pre_delete for TasksModel to avoid OOM when deleting object with many tasks linked#23664
Conversation
…t with many tasks linked Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23664 +/- ##
==========================================
+ Coverage 93.14% 93.19% +0.04%
==========================================
Files 1039 1039
Lines 60860 60868 +8
Branches 424 424
==========================================
+ Hits 56688 56723 +35
+ Misses 4172 4145 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-16a108723ff07a5c1fa180961677c6e4f6ffc45f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-16a108723ff07a5c1fa180961677c6e4f6ffc45fAfterwards, run the upgrade commands from the latest release notes. |
melizeche
left a comment
There was a problem hiding this comment.
looks good to me. Do you think adding tests for task deletion is worth it here or nah?
They will be deleted regardless. This is just us doing it a bit earlier to avoid the OOM |
|
🍒 Cherry-pick to |
Details
What does this PR change?
Why is this change needed?
How was this tested?
Linked issues
Checklist
make all)make docs)