Skip to content

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Oct 7, 2025

Details

This PR adds additional support for a user's preferred level of contrast on inputs and fieldsets. The choice of field colors is deferred to the browser, allowing for default colors (with respect to our theme) to take effect.

Screenshots

Screenshot 2025-10-07 at 05 44 05 Screenshot 2025-10-07 at 05 43 31

@GirlBossRush GirlBossRush requested a review from BeryJu October 7, 2025 03:39
@GirlBossRush GirlBossRush self-assigned this Oct 7, 2025
@GirlBossRush GirlBossRush added the a11y Features or issues related to accessibility label Oct 7, 2025
@GirlBossRush GirlBossRush requested a review from a team as a code owner October 7, 2025 03:39
@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Oct 7, 2025
@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit a243da8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68ff9cbb2dce0700088a3604

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit a243da8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68ff9cbbe6fb7e0008a15ecd
😎 Deploy Preview https://deploy-preview-17279--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit a243da8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68ff9cbb0ef7290008329bfa

@GirlBossRush GirlBossRush force-pushed the a11y-input-preferred-contrast branch from c967e4a to d58c9cf Compare October 7, 2025 03:44
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (12c2343) to head (a243da8).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17279      +/-   ##
==========================================
+ Coverage   92.69%   92.98%   +0.28%     
==========================================
  Files         869      869              
  Lines       47949    47949              
==========================================
+ Hits        44448    44583     +135     
+ Misses       3501     3366     -135     
Flag Coverage Δ
e2e 45.25% <ø> (+1.17%) ⬆️
integration 23.18% <ø> (+<0.01%) ⬆️
unit 91.07% <ø> (+<0.01%) ⬆️
unit-migrate 91.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-a243da8a5dd5e46b073666620ab74bf9bdc0871d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-a243da8a5dd5e46b073666620ab74bf9bdc0871d

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush force-pushed the a11y-input-preferred-contrast branch 4 times, most recently from 8261de0 to 819b35e Compare October 7, 2025 19:44
@GirlBossRush GirlBossRush force-pushed the a11y-input-preferred-contrast branch from 819b35e to a243da8 Compare October 27, 2025 16:24
PFSelect,
css`
.pf-c-select {
--pf-c-select__toggle-wrapper--MaxWidth: unset;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxWidth is a non-heritable property; this should be initial, not unset.

For a property that is inherited (e.g. color) it means inherit, and for a property that isn’t inherited (e.g. float) it means initial. (inherit, initial, unset, revert).

So this will do what you mean, but it's... unclear why it means that. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Features or issues related to accessibility area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants