-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Makefile: Fix kerberos tests on mac #17223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17223 +/- ##
==========================================
- Coverage 92.95% 92.83% -0.12%
==========================================
Files 853 856 +3
Lines 46310 46492 +182
==========================================
+ Hits 43047 43162 +115
- Misses 3263 3330 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ifdef KRB5_EXISTS | ||
PATH="$(shell brew --prefix krb5)/sbin:$(shell brew --prefix krb5)/bin:$$PATH" uv run coverage run manage.py test --keepdb authentik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could probably just export
the changed path and not need to duplicate command
Details
We tell people to install krb5 with brew on dev env setup. The output from running
brew install krb5
tells people they have to update their path to add krb5 manually. This is very easy to miss, and without it in your path, the tests inauthentik/sources/kerberos
will hang infinitely.This PR automatically updates your path to add the brew install of krb5 when the test suite is run via
make test
ormake all
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make docs
)