Skip to content

Conversation

PeshekDotDev
Copy link
Contributor

Details

We tell people to install krb5 with brew on dev env setup. The output from running brew install krb5 tells people they have to update their path to add krb5 manually. This is very easy to miss, and without it in your path, the tests in authentik/sources/kerberos will hang infinitely.

This PR automatically updates your path to add the brew install of krb5 when the test suite is run via make test or make all


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@PeshekDotDev PeshekDotDev requested a review from a team as a code owner October 2, 2025 16:41
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit fb2d33e
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68deab4ed8be000008359fe5
😎 Deploy Preview https://deploy-preview-17223--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit fb2d33e
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68deab4e95150d0008c2e8aa
😎 Deploy Preview https://deploy-preview-17223--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit fb2d33e
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68deab4e6ac2bd0008dc15ac
😎 Deploy Preview https://deploy-preview-17223--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (7e8492a) to head (fb2d33e).
⚠️ Report is 15 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17223      +/-   ##
==========================================
- Coverage   92.95%   92.83%   -0.12%     
==========================================
  Files         853      856       +3     
  Lines       46310    46492     +182     
==========================================
+ Hits        43047    43162     +115     
- Misses       3263     3330      +67     
Flag Coverage Δ
e2e 46.04% <ø> (-0.16%) ⬇️
integration 23.11% <ø> (-0.10%) ⬇️
unit 91.01% <ø> (-0.02%) ⬇️
unit-migrate 91.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +55 to +56
ifdef KRB5_EXISTS
PATH="$(shell brew --prefix krb5)/sbin:$(shell brew --prefix krb5)/bin:$$PATH" uv run coverage run manage.py test --keepdb authentik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could probably just export the changed path and not need to duplicate command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants