perf: show whether plugin toggle is enable or disable #2189
Conversation
There was a problem hiding this comment.
Hello and thank you for your pull request! As is, this PR won't actually alter the behavior indicated, given you're changing translation keys. See the inline PR comments for more details.
If you have any questions, please feel free to let us know and we'll do our best to help out.
Dalamud/Plugin/Internal/Profiles/PluginManagementCommandHandler.cs
Outdated
Show resolved
Hide resolved
Hello! I was thinking about changing
|
|
let me commit that first. if it is not feasible then i revert it |
* Drop special formatting, allowing annotations to work properly. * Suppress duplicate warnings, adding a prefix to prevent annotation * Tweak message, don't rebuild on test * Move testing into same job step * Only run PR build on newly opened PRs * flip build order, derp * Test suppressing summary for annotations... * Get the build order right, testing without conditionals... * Run tests after compile, suppress warnings from test * Reverted previous change to `main.yml`. * Drop special formatting, allowing annotations to work properly. * Suppress duplicate warnings, adding a prefix to prevent annotation * Tweak message, don't rebuild on test * Move testing into same job step * Only run PR build on newly opened PRs * flip build order, derp * Test suppressing summary for annotations... * Get the build order right, testing without conditionals... * Run tests after compile, suppress warnings from test * Reverted previous change to `main.yml`. * Drop special formatting, allowing annotations to work properly. * Suppress duplicate warnings, adding a prefix to prevent annotation * Tweak message, don't rebuild on test * Move testing into same job step * Only run PR build on newly opened PRs * flip build order, derp * Test suppressing summary for annotations... * Get the build order right, testing without conditionals... * Run tests after compile, suppress warnings from test * Reverted previous change to `main.yml`. * Add conditional for CI builds, add --skip-tests to make up for the combined build/test step. * Behavior change, now requires arg `ci` to be passed to trigger tests. Tests can also be manually triggered with `test`.
- Use a Weak Concurrent Collection to track scoped hooks - Make `Hook`s remove themselves from the Tracked Hook list.
KirisameVanilla
force-pushed
the
perf/toggleMessage
branch
from
7700fa9 to
0513d61
Compare
Dalamud/Plugin/Internal/Profiles/PluginManagementCommandHandler.cs
Outdated
Show resolved
Hide resolved
Gotcha :) |
Dalamud/Plugin/Internal/Profiles/PluginManagementCommandHandler.cs
Outdated
Show resolved
Hide resolved
|
Alright, looks good! I'll try to clean up the actual commit history for you. I assume these changes passed local test for you? |
For the commit history, maybe just squash. I ve revert some commits in main branch in order to let the pr only contains my change. For locally testing, i only tested the way of nested call. Ill test it very quickly. plz gimme a few miniutes. |
Tested. Theres no problem. |
|
Verified. Thanks for the contribution! This'll be present in the first release after 7.2! |
Thank you for your guidance! |
when /xltoggleplugin xxx
if xxx is unloaded then shows 'enabling' and 'successfully enable'
if xxx is loaded then shows 'disabling' and 'successfully disable'