This repository has been archived by the owner on Feb 18, 2018. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
a134c3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
It would be great if you could update README.md to explain what the script is doing, so that people who want to manually do it can do so. :)
It's a fantastically useful script!. Could you just tell me what AddBoardId is about and why it needs to be done? Most manual guides on the net don't seem to mention this step.
Thanks.
a134c3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your input. If you wanted all the functionality of what it does, it would be that ~1000 lines of code. If you try to do the same manually, there’s no guarantee that it works. Depends on whether you have a pre-2015 Mac or not, a multi-slot enclosure or not.
Of course there is code that is not very important. For example a secondary screen scrape method for downloading the driver from Nvidia if the primary one fails. And I’ve “encrypted” some nvram values - that’s like a fingerprint, mainly for displaying my copyright notice.
Regarding AddBoardId function, take a look at this thread:
https://www.techinferno.com/index.php?/forums/topic/6772-which-tb2-macbooks-allow-monitors-to-be-used-on-nvidia-egpus-in-osx/&do=findComment&comment=120034
The script executes this part only if it’s necessary.
a134c3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot. :)
I appreciate that it's a non-trivial and carefully written script. Documenting what it does (not how it does it) might go a long way towards more people adopting it and helping you maintain it. Maybe listing out which files are touched, or even just pasting forum links would be of great value.
a134c3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good points. The script has grown a lot due to simultanous Nvidia & AMD support and currently it’s not easily maintainable. I can update the README.md at some point or utilize the Wiki section.