Curve impl #160
Draft
Curve impl #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated API to return []byte and made a SecurityEncryption interface to separate plain/null (no encryption) from curve (with encryption). Found the issue with decryption (wasn't handling the more flag properly). Still need to figure out why encrypt isn't working properly. |
|
Was able to get the encryption working as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting curve implementation from https://github.com/workspace-9/gomq over. Handshake appears to be working correctly for both client and server. Decrypt and encrypt are partially working, but not exactly correct.
Needed to move the encrypt location so that it uses the encrypted payload for the header values. Encrypt also requires the more flag. The API may be able to be adjusted so that the Encrypt/Decrypt functions return a []byte instead of using the Writer/Reader interface. Also, instead of using the same interface for all security implementations (null, plain, and curve). It may make sense to have a small interface for curve that has the encrypt/decrypt since plain and null don't actually do encryption.
Fix #26