Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skip): surface error when failing to determine whether a container should execute #524

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper requested a review from a team as a code owner October 17, 2023 15:07
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #524 (4619be7) into main (26628ba) will decrease coverage by 0.17%.
The diff coverage is 40.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   83.42%   83.26%   -0.17%     
==========================================
  Files          69       69              
  Lines        5371     5389      +18     
==========================================
+ Hits         4481     4487       +6     
- Misses        746      754       +8     
- Partials      144      148       +4     
Files Coverage Δ
internal/step/skip.go 100.00% <100.00%> (ø)
executor/linux/build.go 76.65% <20.00%> (-0.41%) ⬇️
executor/linux/stage.go 84.84% <33.33%> (-1.88%) ⬇️
executor/local/build.go 76.68% <20.00%> (-0.71%) ⬇️
executor/local/stage.go 82.05% <33.33%> (-3.09%) ⬇️

@ecrupper ecrupper merged commit bcdf8e4 into main Oct 17, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the fix/error-on-match-fail branch October 17, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants