Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): Make RunContainer detect/report more error conditions like image pull errors #331

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

feat(k8s): Make RunContainer detect/report more error conditions like image pull errors #331

wants to merge 32 commits into from

Commits on May 4, 2022

  1. feat(k8s): add eventInformer to podTracker

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    2929949 View commit details
    Browse the repository at this point in the history

  2. feat(k8s): ignore event deletion 

    We have nothing to do when that happens.
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    be144f4 View commit details
    Browse the repository at this point in the history

  3. feat(k8s): begin handling event stream

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    7602600 View commit details
    Browse the repository at this point in the history

  4. refactor: create eventInformer from eventInformerFactory 

    we have to use different list options, so they can't share the same factory.
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    457a664 View commit details
    Browse the repository at this point in the history

  5. refactor: rename selector=>labelSelector

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    7d674e8 View commit details
    Browse the repository at this point in the history

  6. enhance: register eventInformerFactory on podTracker

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    71c9b34 View commit details
    Browse the repository at this point in the history

  7. enhance: add podTracker.inspectContainerEvent

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    c3e4b50 View commit details
    Browse the repository at this point in the history

  8. enhance: add signal for running container

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    3e89df6 View commit details
    Browse the repository at this point in the history

  9. enhance: only mark containers as running/terminated if it is the corr… 

    …ect image
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    8ba7ad5 View commit details
    Browse the repository at this point in the history

  10. enhance(k8s): exit WaitContainer if build is canceled

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    038bf97 View commit details
    Browse the repository at this point in the history

  11. enhance(k8s): add containerTracker.Events() function 

    This needs access to the PodTracker's EvenLister, so we create
the function when initializing the containerTracker.
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    b5ab8eb View commit details
    Browse the repository at this point in the history

  12. tests: fix inspectContainerStatuses test

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    57011c1 View commit details
    Browse the repository at this point in the history

  13. bugfix(k8s): Make sure image pull errors are detected

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    639b219 View commit details
    Browse the repository at this point in the history

  14. refactor(k8s): use channels to signal imagePull success/errors

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    092840b View commit details
    Browse the repository at this point in the history

  15. fix: comment typos

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    e3d6d93 View commit details
    Browse the repository at this point in the history

  16. enhance: capture ImagePull errors from ContainerStatuses as well

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    aa1078e View commit details
    Browse the repository at this point in the history

  17. enhance(k8s): handle more image pull event types 

    I've documented a bunch of other event reasons to facilitate
expanded event handling in the future.
Also, I keep running across these messages, so this help
me remember what they are and where they come from.
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9c64abd View commit details
    Browse the repository at this point in the history

  18. tests(k8s): fix tests for RunContainer 

    Now that RunContainer listens for k8s-state changes,
the tests need to actually simulate the state change
like the WaitContainer tests do.
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9686c23 View commit details
    Browse the repository at this point in the history

  19. tests(k8s): test RunContainer and WaitContainer with canceled build

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    dd189e0 View commit details
    Browse the repository at this point in the history

  20. tests(k8s): test AssembleBuild with canceled build

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ca14e32 View commit details
    Browse the repository at this point in the history

  21. tests(k8s): test RunContainer with PodTracker failure (increase cover… 

    …age)
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    2a6d109 View commit details
    Browse the repository at this point in the history

  22. tests(k8s): test inspectContainerStatuses with Running or ImagePullError

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    08c219c View commit details
    Browse the repository at this point in the history

  23. chore: prune some comments

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    40da3f8 View commit details
    Browse the repository at this point in the history

  24. tests: fix inspectContainerStatuses test with an errgroup

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    4726072 View commit details
    Browse the repository at this point in the history

  25. tests: test RunContainer with an ImagePullError

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    0d2f315 View commit details
    Browse the repository at this point in the history

  26. tests: test getTrackedPodEvent

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ccf9fb2 View commit details
    Browse the repository at this point in the history

  27. tests: test podTracker.HandleEventAdd, podTracker.HandleEventUpdate

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    f76339d View commit details
    Browse the repository at this point in the history

  28. refactor: drop unused Events function 

    I'll re-add it later when needed.
    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    e6876d1 View commit details
    Browse the repository at this point in the history

  29. tests: test inspectContainerEvent image pull events

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ecceeac View commit details
    Browse the repository at this point in the history

  30. tests: test inspectContainerEvent edge cases

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    b945f33 View commit details
    Browse the repository at this point in the history

  31. tests: test more pull policies in SetupContainer

    @cognifloyd
    cognifloyd committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9ec81fa View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. chore: delete dead code.

    @cognifloyd
    cognifloyd committed May 5, 2022
    Configuration menu
    Copy the full SHA
    65cbe59 View commit details
    Browse the repository at this point in the history