Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use intermediate env variable for PR title validator #377

Merged
merged 2 commits into from
May 7, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 6, 2024

We have workflow approval settings properly configured, but this is best practice.

See: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable

@ecrupper ecrupper requested a review from a team as a code owner May 6, 2024 18:24
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (fb4a95c) to head (a5c7d94).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          69       69           
  Lines        5361     5361           
=======================================
  Hits         5151     5151           
  Misses        136      136           
  Partials       74       74           

@ecrupper ecrupper merged commit 7c1c741 into main May 7, 2024
8 of 10 checks passed
@ecrupper ecrupper deleted the fix/actions/pr-title-check branch May 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants