Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployments): check for deployment created event action #365

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Mar 19, 2024

adding support for event: [deployment:created]
needed by: go-vela/server#1087

reference: https://go-vela.github.io/docs/usage/repo_settings/#webhook-events

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (f24f795) to head (f37b49a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   96.54%   96.55%           
=======================================
  Files          69       69           
  Lines        5332     5335    +3     
=======================================
+ Hits         5148     5151    +3     
  Misses        110      110           
  Partials       74       74           
Files Coverage Δ
library/events.go 100.00% <100.00%> (ø)
yaml/ruleset.go 100.00% <100.00%> (ø)

library/events.go Outdated Show resolved Hide resolved
ecrupper
ecrupper previously approved these changes Mar 20, 2024
wass3r
wass3r previously approved these changes Mar 21, 2024
@plyr4 plyr4 dismissed stale reviews from ecrupper and wass3r via f37b49a April 10, 2024 13:32
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit cabbb61 into main Apr 10, 2024
10 of 11 checks passed
@plyr4 plyr4 deleted the fix/deployment-created branch April 10, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants