Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(type): worker registration library #307

Merged
merged 13 commits into from
Sep 6, 2023
Merged

feat(type): worker registration library #307

merged 13 commits into from
Sep 6, 2023

Conversation

timhuynh94
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot reviewed Aug 30, 2023
View reviewed changes
library/queue_registration_test.go Outdated Show resolved Hide resolved
library/queue_registration_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #307 (d5ff339) into main (4edd970) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   97.07%   97.08%   +0.01%     
==========================================
  Files          61       62       +1     
  Lines        6792     6828      +36     
==========================================
+ Hits         6593     6629      +36     
  Misses        147      147              
  Partials       52       52
Files Changed Coverage Δ
library/worker_registration.go 100.00% <100.00%> (ø)

@timhuynh94 timhuynh94 mentioned this pull request Aug 30, 2023
Closed
@timhuynh94 timhuynh94 marked this pull request as ready for review August 30, 2023 21:09
@timhuynh94 timhuynh94 requested a review from a team as a code owner August 30, 2023 21:09
ecrupper
ecrupper reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny thing I saw

library/worker_registration_test.go Outdated Show resolved Hide resolved
@timhuynh94 timhuynh94 changed the title queue registration library Feat(type): worker registration library Sep 5, 2023
@wass3r wass3r changed the title Feat(type): worker registration library feat(type): worker registration library Sep 6, 2023
wass3r
wass3r requested changes Sep 6, 2023
View reviewed changes
library/worker_registration_test.go Outdated Show resolved Hide resolved
library/worker_registration.go Outdated Show resolved Hide resolved
wass3r
wass3r requested changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more place to update

library/worker_registration.go Outdated Show resolved Hide resolved
library/worker_registration.go Outdated Show resolved Hide resolved
library/worker_registration.go Outdated Show resolved Hide resolved
library/worker_registration.go Outdated Show resolved Hide resolved
library/worker_registration.go Outdated Show resolved Hide resolved
library/worker_registration.go Outdated Show resolved Hide resolved
@timhuynh94 timhuynh94 merged commit 3829fd1 into main Sep 6, 2023
9 of 10 checks passed
@timhuynh94 timhuynh94 deleted the v21_q_creds branch September 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@wass3r wass3r wass3r approved these changes

@plyr4 plyr4 plyr4 approved these changes

@ecrupper ecrupper Awaiting requested review from ecrupper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timhuynh94 @wass3r @plyr4 @ecrupper