-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for schedules #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 96.90% 97.00% +0.10%
==========================================
Files 57 59 +2
Lines 6329 6545 +216
==========================================
+ Hits 6133 6349 +216
Misses 145 145
Partials 51 51
|
ecrupper
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This meant to still be in draft? LGTM
cognifloyd
approved these changes
May 16, 2023
plyr4
approved these changes
May 16, 2023
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: go-vela/community#538
Part of go-vela/community#772
This adds a new
schedule
event type which will be used in go-vela/server.This also adds some test cases for
ruleset
in thepipeline
andyaml
packages.Additionally, this adds a new
Schedule{}
type to thegithub.com/go-vela/types/database
package:types/database/schedule.go
Lines 29 to 41 in cb989d1
And adds a new
Schedule{}
type to thegithub.com/go-vela/types/library
package:types/library/schedule.go
Lines 11 to 25 in cb989d1
These will be used in the go-vela/server to create a new
schedules
table in the database.