Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker-visibility): extend worker table with 5 fields #277

Merged
merged 15 commits into from
Jun 12, 2023

Conversation

KellyMerrick
Copy link
Contributor

@KellyMerrick KellyMerrick commented Feb 23, 2023

Worker Visibility Proposal: go-vela/community#813

These five fields will be added to the worker table:

  • status
  • last_status_update_at
  • running_build_ids
  • last_build_started_at fields
  • last_build_finished_at fields

See also: go-vela/server#772 and go-vela/worker#482

…us_update_at, running_build_ids, last_build_finished_at fields
@KellyMerrick KellyMerrick self-assigned this Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #277 (2756a45) into main (c0fb629) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   97.00%   97.09%   +0.08%     
==========================================
  Files          59       59              
  Lines        6546     6645      +99     
==========================================
+ Hits         6350     6452     +102     
+ Misses        145      143       -2     
+ Partials       51       50       -1     
Impacted Files Coverage Δ
database/worker.go 100.00% <100.00%> (ø)
library/worker.go 100.00% <100.00%> (+2.94%) ⬆️

@KellyMerrick KellyMerrick marked this pull request as ready for review April 26, 2023 15:36
@KellyMerrick KellyMerrick requested a review from a team as a code owner April 26, 2023 15:36
@KellyMerrick KellyMerrick marked this pull request as draft May 10, 2023 14:24
library/worker.go Outdated Show resolved Hide resolved
@KellyMerrick KellyMerrick changed the title feat(worker-availability): extend worker table with 4 fields feat(worker-visibility): extend worker table with 4 fields May 17, 2023
@KellyMerrick KellyMerrick changed the title feat(worker-visibility): extend worker table with 4 fields feat(worker-visibility): extend worker table with 5 fields Jun 2, 2023
@KellyMerrick KellyMerrick marked this pull request as ready for review June 8, 2023 19:50
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question. lgtm tho

database/worker.go Show resolved Hide resolved
database/worker.go Show resolved Hide resolved
library/worker_test.go Show resolved Hide resolved
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@KellyMerrick KellyMerrick merged commit a13b7ca into main Jun 12, 2023
@KellyMerrick KellyMerrick deleted the worker_visibility branch June 12, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants