fix: use tmp for empty name check (#180)

go-vela · Jun 8, 2021 · bbd070b · bbd070b
1 parent 0de9c0f
commit bbd070b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/yaml/secret.go b/yaml/secret.go
@@ -75,9 +75,14 @@ func (s *SecretSlice) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		return err
 	}
 
+	tmp := SecretSlice{}
+
 	// iterate through each element in the secret slice
 	for _, secret := range *secretSlice {
-		// implicitly set `key` field if empty
+		if len(secret.Name) == 0 {
+			continue
+		}
+
 		if secret.Origin.Empty() && len(secret.Key) == 0 {
 			secret.Key = secret.Name
 		}
@@ -114,10 +119,12 @@ func (s *SecretSlice) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		if !secret.Origin.Empty() && strings.EqualFold(secret.Origin.Pull, "false") {
 			secret.Origin.Pull = constants.PullNotPresent
 		}
+
+		tmp = append(tmp, secret)
 	}
 
 	// overwrite existing SecretSlice
-	*s = *secretSlice
+	*s = tmp
 
 	return nil
 }

diff --git a/yaml/testdata/secret.yml b/yaml/testdata/secret.yml
@@ -1,4 +1,6 @@
 ---
+- source: foo
+  target: bar
 - name: foo
   key: bar
   engine: native