fix(oidc): add expected fields #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 52.16% 52.15% -0.02%
==========================================
Files 550 550
Lines 18833 18839 +6
==========================================
Hits 9825 9825
- Misses 8446 8452 +6
Partials 562 562
|
wass3r
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
thanks. lgtm. fwiw, also seems to align with what github itself uses: https://token.actions.githubusercontent.com/.well-known/openid-configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time over this weekend experimenting with the new OIDC feature and noticed that the
/_services/token/.well-known/openid-configurationendpoint doesn't align with AWS's expected format for openid. AWS's documentation specifies the required fields, which you can find at https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc.html#manage-oidc-provider-prerequisites. After updating the API response to include all of these fields, the issue was resolved.openid documents the discovery endpoint schema within https://openid.net/specs/openid-connect-discovery-1_0.html.