fix(queue): pop from inRoutes if supplied (#1153)

* fix(queue): pop from inRoutes if supplied * move log message to be accurate * remove errant line --------- Co-authored-by: Tim Huynh <[email protected]>
go-vela · Jun 24, 2024 · b24411e · b24411e
1 parent 71d4cfd
commit b24411e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/queue/redis/pop.go b/queue/redis/pop.go
@@ -15,18 +15,18 @@ import (
 
 // Pop grabs an item from the specified channel off the queue.
 func (c *client) Pop(ctx context.Context, inRoutes []string) (*models.Item, error) {
-	c.Logger.Tracef("popping item from queue %s", c.GetRoutes())
-
 	// define routes to pop from
 	var routes []string
 
 	// if routes were supplied, use those
-	if len(routes) > 0 {
+	if len(inRoutes) > 0 {
 		routes = inRoutes
 	} else {
 		routes = c.GetRoutes()
 	}
 
+	c.Logger.Tracef("popping item from queue %s", routes)
+
 	// build a redis queue command to pop an item from queue
 	//
 	// https://pkg.go.dev/github.com/go-redis/redis?tab=doc#Client.BLPop