chore: rename settings FromAPI constructor (#1126)

Co-authored-by: Easton Crupper <[email protected]>
go-vela · May 13, 2024 · 9357113 · 9357113
1 parent 6a9e509
commit 9357113
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/database/settings/create.go b/database/settings/create.go
@@ -14,7 +14,7 @@ func (e *engine) CreateSettings(_ context.Context, s *settings.Platform) (*setti
 	e.logger.Tracef("creating platform settings in the database with %v", s.String())
 
 	// cast the api type to database type
-	settings := types.FromAPI(s)
+	settings := types.SettingsFromAPI(s)
 
 	// validate the necessary fields are populated
 	err := settings.Validate()

diff --git a/database/settings/update.go b/database/settings/update.go
@@ -14,7 +14,7 @@ func (e *engine) UpdateSettings(_ context.Context, s *settings.Platform) (*setti
 	e.logger.Trace("updating platform settings in the database")
 
 	// cast the api type to database type
-	dbS := types.FromAPI(s)
+	dbS := types.SettingsFromAPI(s)
 
 	// validate the necessary fields are populated
 	err := dbS.Validate()

diff --git a/database/types/settings.go b/database/types/settings.go
@@ -194,9 +194,9 @@ func (ps *Platform) Validate() error {
 	return nil
 }
 
-// FromAPI converts the API Settings type
+// SettingsFromAPI converts the API Settings type
 // to a database Settings type.
-func FromAPI(s *settings.Platform) *Platform {
+func SettingsFromAPI(s *settings.Platform) *Platform {
 	settings := &Platform{
 		ID: sql.NullInt64{Int64: s.GetID(), Valid: true},
 		Compiler: Compiler{

diff --git a/database/types/settings_test.go b/database/types/settings_test.go
@@ -166,7 +166,7 @@ func TestTypes_Platform_PlatformFromAPI(t *testing.T) {
 	want := testPlatform()
 
 	// run test
-	got := FromAPI(s)
+	got := SettingsFromAPI(s)
 
 	if !reflect.DeepEqual(got, want) {
 		t.Errorf("PlatformFromAPI is %v, want %v", got, want)