Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add approve build method to build service #276

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner December 11, 2023 21:30
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #276 (5338377) into main (51b27c4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   91.75%   91.78%   +0.02%     
==========================================
  Files          20       20              
  Lines        1456     1461       +5     
==========================================
+ Hits         1336     1341       +5     
  Misses         86       86              
  Partials       34       34              
Files Coverage Δ
vela/build.go 95.12% <100.00%> (+0.20%) ⬆️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 23e6a2e into main Dec 11, 2023
10 checks passed
@ecrupper ecrupper deleted the feat/build/approve branch December 11, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants